enhance: “つながりの公開範囲”がフォロー・フォロワー個別設定できるように #12702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12702 +/- ##
===========================================
+ Coverage 79.65% 81.74% +2.09%
===========================================
Files 955 178 -777
Lines 107713 27337 -80376
Branches 8351 511 -7840
===========================================
- Hits 85796 22347 -63449
+ Misses 21917 4990 -16927 ☔ View full report in Codecov by Sentry. |
zawa-ch
changed the title
|
わかりました、この部分は差し戻します
ア！ |
修正しました |
syuilo
reviewed
Dec 18, 2023
locales/ja-JP.yml
Outdated
| ffVisibility: "つながりの公開範囲" | ||
| ffVisibilityDescription: "自分のフォロー/フォロワー情報の公開範囲を設定できます。" | ||
| followingVisibility: "フォローの公開範囲" | ||
| followingVisibilityDescription: "自分のフォロー情報の公開範囲を設定できます。" |
There was a problem hiding this comment.
「つながり」から「フォロー/フォロワー」と具体的な呼称に変わったから特にdescriptionは要らなそう
locales/ja-JP.yml
Outdated
| followingVisibility: "フォローの公開範囲" | ||
| followingVisibilityDescription: "自分のフォロー情報の公開範囲を設定できます。" | ||
| followersVisibility: "フォロワーの公開範囲" | ||
| followersVisibilityDescription: "自分のフォロワー情報の公開範囲を設定できます。" |
名称が具体的になって必要なくなったため misskey-dev#12702 (comment)
|
|
|
👍👍 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* Enhance: “つながりの公開範囲”がフォロー・フォロワー個別設定できるように (misskey-dev#12072) * refactor: crowdin 編集部分のコミットを打ち消し misskey-dev#12702 (comment) * refactor: オブジェクトの名前修正 misskey-dev#12702 (comment) * fix: 設定項目の説明を削除 名称が具体的になって必要なくなったため misskey-dev#12702 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
このPRは「つながりの公開範囲」をフォロー/フォロワーで個別に設定できるようになります。
Why
このPRは #12072 を解決することができます。 (Resolve #12072)
Additional info (optional)
Checklist