Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): Verifymail.io API設定項目の名前をきちんとサービスの名前で表記する #12753

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

nafu-at
Copy link
Contributor

@nafu-at nafu-at commented Dec 23, 2023

What

きちんとサービス名を表記しなかった事により若干の混乱が生じているように見受けられたため。

Why

どこのサービスのAPIを使うのか分かりやすくする。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 23, 2023
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c7d07b) 79.79% compared to head (e185f39) 79.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12753      +/-   ##
===========================================
- Coverage    79.79%   79.78%   -0.02%     
===========================================
  Files          956      956              
  Lines       108801   108801              
  Branches      8372     8371       -1     
===========================================
- Hits         86817    86805      -12     
- Misses       21984    21996      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 30cf5c3 into misskey-dev:develop Dec 23, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 23, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants