fix(backend): 1702718871541-ffVisibility.jsのdownが壊れている

[samunohito]

What

掲題の現象を修正しました。
これにより、pmpm revertが成功するようになります。

Why

2023.12.0への更新に失敗した時など、前のバージョンまで巻き戻したいケースがあると考えます。

Additional info (optional)

ローカルにてpnpm migrateとpnpm revertを繰り返し実行し、いずれもエラーとならないこと、user_profile.ffVisibilityの値が壊れずに引き継がれることを確認しています。

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md ※別途相談したいです
• (If possible) Add tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (471c8ec) 79.79% compared to head (c28403f) 79.79%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #12767   +/-   ##
========================================
  Coverage    79.79%   79.79%           
========================================
  Files          956      956           
  Lines       108800   108800           
  Branches      8373     8374    +1     
========================================
  Hits         86814    86814           
  Misses       21986    21986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samunohito]

2023.12.0をmasterにリリースしたことにより起票されたと思われるissueの確認をしていたところで発見したバグです。
developだけでなく、masterへのhotfix的なアプローチが必要だと考えます

[temtemy]

Hey, I am that person at #12764 who got a fatal failure in upgrading to 2023.12.0 and couldn't get back to the previous version because I already did the database migration and didn't do a database dump before upgrading... I found this PR from the discord guild's notification channels; I assume this would allow my Misskey to safely downgrade back to 2023.11.1 without a database dump restore?

Just so I do not damage my chances of getting my Misskey instance back fully working again, I would like to make sure I know what I am going to do with this is right. Please correct me if the steps I plan to do is wrong:

1. Pull this PR to my own branch which is currently at master
2. pnpm migrate so that the new 1702718871541-ffVisibility.js gets applied
3. pnpm revert
4. Checkout 2023.11.1 and redo the pnpm install, pnpm run build, and pnpm migrate (though this last command seems unnecessary I think) steps
5. Restart Misskey and 🙏 it works

[temtemy]

I decided to do a hallelujah and applied this PR and my plan. It worked! https://makai.chaotic.ninja/notes/9nme23ch04

Thank you very much!!!

[samunohito]

Sorry for the late reply.

This was intended to fix a bug I found while checking the steps to address #12764. However, I did not want to link to it directly because there was no guarantee that this would fix the problem.

I am happy to solve the problem you are having.

[syuilo]

🙏🏻