fix(drop-and-fusion): バブルゲームのリトライボタンでリトライができない問題を修正 #12957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ゲーム中なら諦める、ゲームオーバー画面の表示中はリスタートになるように
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12957 +/- ##
========================================
Coverage 76.86% 76.86%
========================================
Files 176 176
Lines 22848 22848
Branches 430 430
========================================
Hits 17561 17561
Misses 5287 5287 ☔ View full report in Codecov by Sentry. |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ゲーム中なら諦める、ゲームオーバー画面の表示中はリスタートになるように
一部の値がゲーム終了時初期化されていないのも直した
Why
リトライって書いてあるボタンを押すとゲームオーバー画面になるだけなのでユーザーの期待通りの動きではなくなっている
Additional info (optional)
ioではすでに適用済み
MisskeyIO#350
Checklist