Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pnpm build-misskey-js-with-types #12972

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

What

cf54c2b で misskey-js のビルドが行われていなかったためにテストが落ちていた問題を修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review January 11, 2024 14:33
@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/misskey-js labels Jan 11, 2024
@kakkokari-gtyih
Copy link
Contributor Author

テスト通ったらマージする

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -70266,9 +70266,6 @@
           "description": "Source code",
           "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/bubble-game/register.ts"
         },
-        "tags": [
-          null
-        ],
         "security": [
           {
             "bearerAuth": []
@@ -70467,9 +70464,6 @@
           "description": "Source code",
           "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/bubble-game/ranking.ts"
         },
-        "tags": [
-          null
-        ],
         "requestBody": {
           "required": true,
           "content": {
@@ -70636,9 +70630,6 @@
           "description": "Source code",
           "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/bubble-game/ranking.ts"
         },
-        "tags": [
-          null
-        ],
         "requestBody": {
           "required": true,
           "content": {

Get diff files from Workflow Page

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf54c2b) 64.13% compared to head (40a34a4) 63.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12972      +/-   ##
===========================================
- Coverage    64.13%   63.86%   -0.27%     
===========================================
  Files          957      961       +4     
  Lines       104929   109462    +4533     
  Branches      5466     5249     -217     
===========================================
+ Hits         67291    69905    +2614     
- Misses       37638    39557    +1919     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih merged commit be57ff4 into misskey-dev:develop Jan 11, 2024
20 checks passed
@kakkokari-gtyih kakkokari-gtyih deleted the run-mi-js-build-240111-0 branch January 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant