enhance(frontend): リアクションの総数を表示するか設定で選べるように #13539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3c8475e)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13539 +/- ##
===========================================
- Coverage 77.68% 77.51% -0.18%
===========================================
Files 185 183 -2
Lines 25049 24859 -190
Branches 484 484
===========================================
- Hits 19460 19270 -190
Misses 5582 5582
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
リアクション総数、デフォルト非表示でも良いかもしれない |
…ri-gtyih/misskey into enh-notecount-settings-1
|
返信数とリノート数は隠せる必要あるかしら |
|
ioから引っ張ってきたので詳細はわからない（「なんでリアクションは隠せるのに…？」となる可能性を見越した？） |
|
とりあえずリアクションだけで良さそう |
|
リアクションだけになったはず |
|
まだだった |
|
いけたかも |
kakkokari-gtyih
changed the title
tamaina
reviewed
Mar 7, 2024
tamaina
approved these changes
Mar 7, 2024
|
🙏 |
n1lsqn
pushed a commit
to n1lsqn/misskey
that referenced
this pull request
Mar 10, 2024
* enhance(frontend): リプライ・リノート・リアクションの総数を表示するか設定で選べるように (MisskeyIO#512) (cherry picked from commit 3c8475e) * fix: いいねのみの場合は強制的にカウント表示 * make `showReactionsCount` default false * リアクションだけ * けしわすれ * けしわすれ２ --------- Co-authored-by: まっちゃとーにゅ <17376330+u1-liquid@users.noreply.github.com>
kanarikanaru
added a commit
to kanarikanaru/misskey
that referenced
this pull request
Mar 13, 2024
This reverts commit 27f823e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
書いてあるとおり
Cherry-picked from MisskeyIO#512
Why
非表示にする設定を入れていなかったので
Additional info (optional)
ioからの変更点
reactionAcceptanceが「いいねのみ」の場合は強制的にカウントを表示するように（カウントを知る術がなくなるので）
（使った感じから切っといたほうが良いと判断）
Checklist