Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プラグインの簡易的なログを表示する機能 #13564

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

FineArchs
Copy link
Contributor

@FineArchs FineArchs commented Mar 12, 2024

設定>プラグインのページから、プラグインの標準出力のログやエラーメッセージを見られるようにしました。

副作用として、プラグインが1つエラーを起こした時に即時停止するようになりました。これはaiscriptのJavaScript APIを利用する都合上のものであり、aiscript側を改変することで解消可能なので、要望があればそのようにします。

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (6b676a9) to head (23d994a).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13564       +/-   ##
============================================
+ Coverage    66.09%   77.69%   +11.59%     
============================================
  Files          990      185      -805     
  Lines       115462    25053    -90409     
  Branches      5750      484     -5266     
============================================
- Hits         76311    19464    -56847     
+ Misses       37715     5582    -32133     
+ Partials      1436        7     -1429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 88d47ab into misskey-dev:develop Mar 13, 2024
15 of 17 checks passed
@syuilo
Copy link
Member

syuilo commented Mar 13, 2024

🆒

@FineArchs FineArchs deleted the pluglog branch March 13, 2024 14:29
@tai-cha
Copy link
Contributor

tai-cha commented Mar 14, 2024

AiScriptに例外処理がないので一つエラー起こしたら止まるのは少ししんどさがあるかもしれないです

https://github.com/aiscript-dev/aiscript/blob/master/docs%2Fget-started.md#%E3%82%A8%E3%83%A9%E3%83%BC%E5%9E%8B

@FineArchs
Copy link
Contributor Author

これはaiscriptのJavaScript APIを利用する都合上のものであり、aiscript側を改変することで解消可能なので、要望があればそのようにします。

やってみます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants