Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): flash/createでPlayの公開範囲を指定できない問題の修正と編集画面の調整 #13574

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

zyoshoka
Copy link
Contributor

What

以下のことを行いました。

  • flash/create エンドポイントに visibility パラメーターを追加
    • デフォルト値を public にし省略可能にしたため破壊的変更ではありません
  • Play の編集画面の UI 調整
    • 「公開範囲」が「保存」ボタンの上に来るように
      • そのほうが自然そうですので
    • 「公開範囲」についての説明を追加
      • 単に「公開範囲」だと URL からアクセスできることに気づかない人もいらっしゃるだろうと思いましたので

Why

Resolves #13572

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Mar 13, 2024
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -60805,6 +60805,14 @@
                     "items": {
                       "type": "string"
                     }
+                  },
+                  "visibility": {
+                    "type": "string",
+                    "enum": [
+                      "public",
+                      "private"
+                    ],
+                    "default": "public"
                   }
                 },
                 "required": [

Get diff files from Workflow Page

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.09%. Comparing base (5c1d86b) to head (966d7ee).
Report is 2 commits behind head on develop.

Files Patch % Lines
...s/backend/src/server/api/endpoints/flash/create.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13574      +/-   ##
===========================================
- Coverage    64.83%   61.09%   -3.75%     
===========================================
  Files          986      801     -185     
  Lines       111009    85988   -25021     
  Branches      4424     5203     +779     
===========================================
- Hits         71974    52532   -19442     
+ Misses       39003    33431    -5572     
+ Partials        32       25       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyoshoka zyoshoka changed the title fix(general): flash/createでPageの公開範囲を指定できない問題の修正と編集画面の調整 fix(general): flash/createでPlayの公開範囲を指定できない問題の修正と編集画面の調整 Mar 13, 2024
@syuilo syuilo merged commit 4b1ca9e into misskey-dev:develop Mar 15, 2024
25 of 27 checks passed
@syuilo
Copy link
Member

syuilo commented Mar 15, 2024

🙏

@zyoshoka zyoshoka deleted the fix-page-visibility branch March 15, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play 作成時に公開範囲を変更しても反映されない
2 participants