Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): some fixes and improvements of Play visibility #14384

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

zyoshoka
Copy link
Contributor

@zyoshoka zyoshoka commented Aug 9, 2024

What

  • 「自分のPlay」ページにおいて Play が非公開かどうかが一目でわかるように
    • 見え方に関しては Chromatic を参照してください
  • Play 編集時に公開範囲が「パブリック」にリセットされる問題を修正
  • Play 各種エンドポイントの返り値に visibility が含まれていない問題を修正
    • permissions も同様の問題を抱えていますが、現状使われていないようなのでこの PR では対応していません

Why

Closes #14379

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -79948,6 +79948,13 @@
           "script": {
             "type": "string"
           },
+          "visibility": {
+            "type": "string",
+            "enum": [
+              "private",
+              "public"
+            ]
+          },
           "likedCount": {
             "type": [
               "number",
@@ -79967,6 +79974,7 @@
           "title",
           "summary",
           "script",
+          "visibility",
           "likedCount"
         ]
       },

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 7.24638% with 64 lines in your changes missing coverage. Please review.

Project coverage is 41.80%. Comparing base (f509413) to head (ccad695).

Files Patch % Lines
...tend/src/components/MkFlashPreview.stories.impl.ts 0.00% 52 Missing and 1 partial ⚠️
...ackages/frontend/src/components/MkFlashPreview.vue 0.00% 9 Missing ⚠️
...es/backend/src/core/entities/FlashEntityService.ts 0.00% 1 Missing ⚠️
packages/frontend/src/pages/flash/flash-edit.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14384      +/-   ##
===========================================
+ Coverage    39.92%   41.80%   +1.87%     
===========================================
  Files         1544     1549       +5     
  Lines       190430   196545    +6115     
  Branches      3550     3585      +35     
===========================================
+ Hits         76031    82165    +6134     
- Misses      113809   113819      +10     
+ Partials       590      561      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 01a815f into misskey-dev:develop Aug 10, 2024
27 of 28 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 10, 2024

🙏

@zyoshoka zyoshoka deleted the flash-show-visibility branch August 10, 2024 04:38
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
…-dev#14384)

* fix(backend): missing `visibility` param in packing flash

* fix(frontend): use `visibility` value got from API

* enhance(frontend): change preview appearance of private Play

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
2 participants