Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(beckend): html content-type detection on signedGet #14424

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Aug 17, 2024

What

Why

#14391 (comment)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 17, 2024
@tai-cha
Copy link
Contributor Author

tai-cha commented Aug 17, 2024

なんかログが変

Copy link
Contributor

github-actions bot commented Aug 17, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.87%. Comparing base (129af06) to head (f94e3d9).
Report is 1 commits behind head on develop.

Files Patch % Lines
...s/backend/src/core/activitypub/ApRequestService.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14424      +/-   ##
===========================================
- Coverage    39.87%   39.87%   -0.01%     
===========================================
  Files         1547     1547              
  Lines       190886   190886              
  Branches      3506     3553      +47     
===========================================
- Hits         76116    76114       -2     
- Misses      114208   114210       +2     
  Partials       562      562              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tai-cha
Copy link
Contributor Author

tai-cha commented Aug 17, 2024

また変なの混じった

@tai-cha tai-cha requested a review from anatawa12 August 17, 2024 10:47
Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tai-cha tai-cha merged commit bf8c42e into develop Aug 17, 2024
26 checks passed
@tai-cha tai-cha deleted the fix/contenttype branch August 17, 2024 10:51
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
…4424)

* fix(backend): contenttype detection of html in signedGet

* code style

* fix by review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants