fix(frontend): 連合一覧等のページネーションが壊れていたのを修正 #14439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samunohito
commented
Aug 19, 2024
| scrollRemove.value = (props.pagination.reversed ? onScrollBottom : onScrollTop)(contentEl.value, executeQueue, TOLERANCE); | ||
| scrollRemove.value = props.pagination.reversed | ||
| ? onScrollBottom(contentEl.value, executeQueue, TOLERANCE) | ||
| : onScrollTop(contentEl.value, (topVisible) => { if (topVisible) executeQueue(); }, TOLERANCE); |
There was a problem hiding this comment.
上から下に向かってスクロールするときは発動させず、下から上に向かってスクロールしたときに発動するようにしています。
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14439 +/- ##
============================================
- Coverage 41.47% 19.48% -22.00%
============================================
Files 1545 714 -831
Lines 197945 100663 -97282
Branches 3568 998 -2570
============================================
- Hits 82104 19612 -62492
+ Misses 115247 80506 -34741
+ Partials 594 545 -49 ☔ View full report in Codecov by Sentry. |
5 tasks
|
scroll.tsがfrontend-sharedに移動したので書き直す必要あり |
|
やるか |
|
コンフリクト解消 |
|
🙏🏻 |
HotoRas
pushed a commit
to HotoRas/misskey-neko
that referenced
this pull request
Sep 27, 2024
* fix * fix * fix CHANGELOG.md * 開発環境以外でログが出ないように --------- Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
MkPaginationを用いて複数の項目を横に並べるような画面にて、無限スクロールが上手く働かないケースがある現象を修正しました。
→連続でコールバックしないように処置を施した
→offsetとして分けておく必要はなさそうなのでitems.value.sizeを使うようにした
Why
fix #12766
fix #11449
Additional info (optional)
実際にローカルと自鯖にて動作確認
Checklist