Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): weird AP delivered chart in control panel #14481

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

zyoshoka
Copy link
Contributor

What

コントロールパネル内の Ap requests 内のチャートの表示がおかしかった問題を修正します。

Why

Closes #13350
Closes #14480

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 19.61%. Comparing base (cd247b9) to head (95f6e8e).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...c/pages/admin/overview.ap-requests.stories.impl.ts 0.00% 40 Missing and 1 partial ⚠️
.../frontend/src/pages/admin/overview.ap-requests.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14481       +/-   ##
============================================
- Coverage    39.56%   19.61%   -19.96%     
============================================
  Files         1541      715      -826     
  Lines       192648   101070    -91578     
  Branches      3529      985     -2544     
============================================
- Hits         76229    19824    -56405     
+ Misses      115823    80702    -35121     
+ Partials       596      544       -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 19, 2024
@kakkokari-gtyih
Copy link
Contributor

👀

@zyoshoka zyoshoka changed the title fix(frontend): weird AP derivered chart in control panel fix(frontend): weird AP delivered chart in control panel Sep 23, 2024
@syuilo syuilo merged commit a37df2c into misskey-dev:develop Sep 24, 2024
8 of 9 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 24, 2024

🙏🏻

@zyoshoka zyoshoka deleted the control-panel-ap-requests-chart branch September 24, 2024 00:56
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
…#14481)

* fix(frontend): `Out: Fail` was negative number

* fix(frontend): don't stack AP delivered chart

* test(misskey-dev#10336): add `pages/admin/overview.ap-requests.vue` story

* Update CHANGELOG.md

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
3 participants