Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(misskey-js): warnを除去 #14520

Conversation

kakkokari-gtyih
Copy link
Contributor

What

#14508 で重複する条件判定を入れたためmisskey-jsにwarnが出るようになった
それを消す

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.55%. Comparing base (567acea) to head (64cdd1f).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14520       +/-   ##
============================================
+ Coverage    20.16%   41.55%   +21.39%     
============================================
  Files          725     1551      +826     
  Lines       100579   196719    +96140     
  Branches      1045     3568     +2523     
============================================
+ Hits         20279    81754    +61475     
- Misses       79758   114373    +34615     
- Partials       542      592       +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KisaragiEffective
Copy link
Collaborator

自明なのでマージ

@KisaragiEffective KisaragiEffective merged commit 0d0cd73 into misskey-dev:develop Sep 6, 2024
22 checks passed
@kakkokari-gtyih kakkokari-gtyih deleted the refactor-remove-misskeyjs-lint-warn branch September 6, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants