Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkDateSeparatedListで月の違う同じ日はセパレータが出ないのを修正 #14545

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

年・月・日すべてが同じかどうかを確かめるように

Why

Fix #909

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 19.72%. Comparing base (837a8e1) to head (42ae654).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...es/frontend/src/components/MkDateSeparatedList.vue 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14545      +/-   ##
===========================================
+ Coverage    19.53%   19.72%   +0.18%     
===========================================
  Files          713      713              
  Lines       100287   100294       +7     
  Branches       997      995       -2     
===========================================
+ Hits         19591    19781     +190     
+ Misses       80152    79971     -181     
+ Partials       544      542       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 13, 2024
@syuilo syuilo merged commit e0f54d6 into misskey-dev:develop Sep 15, 2024
20 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-909 branch September 15, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

月の違う同じ日はセパレータが表示されない
2 participants