Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey-js): wrong hashtag channel param type #14611

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

zyoshoka
Copy link
Contributor

What

misskey-js で hashtag チャンネルに接続する際の引数の型がおかしいのを修正します。

Why

引数にただの文字列を指定(もしくは省略)するのでは正しく動作しませんので

public async init(params: JsonObject) {
if (!Array.isArray(params.q)) return;
if (!params.q.every(x => Array.isArray(x) && x.every(y => typeof y === 'string'))) return;

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.36%. Comparing base (f93a575) to head (e5833af).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14611      +/-   ##
===========================================
+ Coverage    39.73%   41.36%   +1.63%     
===========================================
  Files         1539     1543       +4     
  Lines       192271   198008    +5737     
  Branches      3479     2499     -980     
===========================================
+ Hits         76401    81914    +5513     
- Misses      115278   115532     +254     
+ Partials       592      562      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 22, 2024
@syuilo syuilo merged commit 2c61535 into misskey-dev:develop Sep 23, 2024
24 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 23, 2024

🙏🏻

@zyoshoka zyoshoka deleted the wrong-hashtag-ch-param branch September 23, 2024 03:27
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants