Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sassのmodern-compilerを使うように #14651

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

AmaseCocoa
Copy link
Contributor

What

ビルド時にLegacy JS APIに関する警告が出る問題を修正するためにmodern-compilerを利用してscssをビルドするようにしました。

Why

Dart Sass 2.0.0でLegacy JS APIが削除される予定なため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.71%. Comparing base (e9519b0) to head (775a766).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14651       +/-   ##
============================================
- Coverage    41.40%   19.71%   -21.70%     
============================================
  Files         1549      716      -833     
  Lines       199468   101490    -97978     
  Branches      3623      985     -2638     
============================================
- Hits         82595    20005    -62590     
+ Misses      116276    80941    -35335     
+ Partials       597      544       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit a25d83f into misskey-dev:develop Oct 3, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 3, 2024

🙏🏿

Natsuki-Kaede pushed a commit to paricafe/misskey that referenced this pull request Oct 3, 2024
* fix(frontend-embed): ビルド時にsassのmodern-compilerを使うように

* fix(frontend): ビルド時にsassのmodern-compilerを使うように
@AmaseCocoa AmaseCocoa deleted the sass-modern-compiler branch October 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants