ActivityPubでリモートのオブジェクトをGETするときのリクエストをHTTP Signatureで署名するオプション #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
詳細な説明あざます！今から見ます
👍
あー、ここ見落としてました。後で直しておきます💪 |
syuilo
reviewed
Oct 17, 2020
| @@ -5,6 +5,7 @@ import fetch, { HeadersInit } from 'node-fetch'; | |||
| import { HttpProxyAgent } from 'http-proxy-agent'; | |||
| import { HttpsProxyAgent } from 'https-proxy-agent'; | |||
| import config from '../config'; | |||
| import { URL } from 'url'; | |||
|
👍👍👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #6727
ActivityPubでリモートのオブジェクトをGETするときのリクエストをHTTP Signatureで署名するオプション追加。
default.ymlに
signToActivityPubGet: true, (default: false)このオプションを有効にすると、
Mastodon v3.x の以下のオプションなどで署名を強制しているサーバーからオブジェクトを取得できるようになります。
https://docs.joinmastodon.org/admin/config/#basic
ただし、このオプションを有効にするデメリットは
がある割に、このオプションが必要なMastodonサーバーがほぼないと思われるためデフォルトでは有効にしてません。
実装メモ
instance.actorという名前のシステムユーザーを作成して行いますまた、以下のバグを潰さないと動かないので雑に修正しています