SchemaTypeの型計算量を削減 #8332
Merged
SchemaTypeの型計算量を削減 #8332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
エラーが118から125に増えた |
|
草 |
|
型がちゃんと検査されているということかしら？それともこれが原因で型が間違ったものになった？ |
|
120に減らしてみた |
後者かと思ったけど前者かも(未確認) |
|
後者だと思う optionalまわりがまずいことになってそうだと思っている |
|
まずいことになっているのを直した |
|
（型計算量減らしてもダメな時はダメ） |
|
逆に今まで問題なかったところで が出るようになってるわね(endpoints/test.tsなど) まあafterの方がシンプルになっているしYOSASOU |
|
🙏🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
型のインスタンス化は非常に深く、無限である可能性があります。が出ている箇所があったため、ちょっと計算量を減らすように