feat: option to collapse long notes #8561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added en-US manually while testing, did not commit that file as it will be overwritten by Crowdin.
It has no effect on other variations (short message, has cw)
|
Johann150
reviewed
Apr 29, 2022
|
It was a bit hard to find something that makes it well visible on both light and dark themes. |
Johann150
reviewed
Apr 29, 2022
Johann150
approved these changes
Apr 29, 2022
|
👍 |
|
Why was it reverted? |
|
There was a problem with URL previews and images being cropped. |
|
I tried with images, with link previews, and with both but I did not notice any problems. 😕 |
Johann150
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts commit 71150f2 and reinstates the option to collapse long notes again after they were expanded.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an option to re-collapse long messages.
Why
Opening long messages on the timeline can make it hard to scroll back and forth, that mostly results in a "meh, I'll just refresh the page"
Additional info (optional)
Please give me a string value for "Show less" in Japanese, Got a tip to use "閉じる", if it's not the right one, let me know. As I understand, the new keyword will get into the flow if it has a Japanese value, the rest come from Crowdin (that's why I did not commit any other languages/translations).
Closes #8559