Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dev Containerの設定を修正 #9921

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

Ry0taK
Copy link
Contributor

@Ry0taK Ry0taK commented Feb 13, 2023

What

  • Dev Containerの起動時にプロジェクトディレクトリの権限を適切に変更するように
  • Dev Container内にプロジェクトディレクトリの親ディレクトリが含まれていた問題を修正
  • PostgreSQLとRedisのデータをマウントしたディレクトリではなくVolume内に保持するように
  • CONTRIBUTING.mdにWindowsで実行する際はWSL内でcloneするべきという旨を記載

Why

  1. Dev Containerの設定 init.sh #9917 において一部のケースにおいてファイルの権限が適切に設定されていない場合があることが判明したため
  2. プロジェクトディレクトリの親ディレクトリはMisskeyの開発環境に必要無いため
  3. Git for Windowsでcloneしてしまうとファイルの改行がCRLFで行われるようになってしまい、壊れるため

Additional info (optional)

Closes #9917 (一部の挙動が手元で再現できなかったため完全に修正されるかが確認できず)

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #9921 (455a4b7) into develop (e8d4f3e) will not change coverage.
The diff coverage is n/a.

❗ Current head 455a4b7 differs from pull request most recent head 5f046fc. Consider uploading reports for the commit 5f046fc to get more accurate results

@@           Coverage Diff            @@
##           develop    #9921   +/-   ##
========================================
  Coverage    22.89%   22.89%           
========================================
  Files          729      729           
  Lines        68004    68004           
  Branches      2069     2069           
========================================
  Hits         15568    15568           
  Misses       52436    52436           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Ry0taK Ry0taK marked this pull request as ready for review February 13, 2023 12:49
@syuilo syuilo merged commit c7fbf56 into misskey-dev:develop Feb 14, 2023
@syuilo
Copy link
Member

syuilo commented Feb 14, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Containerの設定 init.sh
2 participants