Skip to content

Commit

Permalink
build: fix use of strict aliasing
Browse files Browse the repository at this point in the history
The -fno-strict-aliasing flag was added to fix compilation warnings when
building Node.js with GCC <= 4.4

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: nodejs#9179
  • Loading branch information
trevnorris authored and Julien Gilli committed May 7, 2015
1 parent ff84827 commit d07b6e2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions deps/uv/uv.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@
'src/version.c'
],
'conditions': [
[ 'gcc_version<=44', {
# GCC versions <= 4.4 do not handle the aliasing in the queue
# implementation, so disable aliasing on these platforms
# to avoid subtle bugs
'cflags': [ '-fno-strict-aliasing' ],
}],
[ 'OS=="win"', {
'defines': [
'_WIN32_WINNT=0x0600',
Expand Down

0 comments on commit d07b6e2

Please sign in to comment.