fix dependencies specification #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current dependency section doesn't work as expected and actually breaks dependencies for users of poetry. See https://python-poetry.org/docs/dependency-specification/#version-constraints Notably for `httpx`: any user who wants to use a package that requires a recent version of httpx will be left in a hell of "version solving failed" because the semver used actually limits to `<=0.26.0` (instead of the 1.0.0 which was the intent but poorly specificied).
|
(note: if ok, we need to regenerate a |
|
thanks for the report @antoine-lizee this is fixed in the latest release (version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current dependency section doesn't work as expected and actually breaks dependencies for users of poetry.
See https://python-poetry.org/docs/dependency-specification/#version-constraints
Notably for
httpx: any user who wants to use a package that requires a recent version of httpx will be left in a hell of "version solving failed" because the semver used actually limits to<=0.26.0(instead of the 1.0.0 which was the intent but poorly specificied).Note: I kept
^specification when relevant, but we might want to use>= , <everywhere instead to be more consistent.