fix: get api key at client initialisation: #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's done at interpretation time, disallowing environment modification
|
You are right thank you very much for your contribution! |
fuegoio
approved these changes
May 23, 2024
wilsonsilva
added a commit
to wilsonsilva/mistral
that referenced
this pull request
May 23, 2024
wilsonsilva
added a commit
to wilsonsilva/mistral
that referenced
this pull request
May 23, 2024
wilsonsilva
added a commit
to wilsonsilva/mistral
that referenced
this pull request
May 23, 2024
wilsonsilva
added a commit
to wilsonsilva/mistral
that referenced
this pull request
May 23, 2024
wilsonsilva
added a commit
to wilsonsilva/mistral
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's done at interpretation time, disallowing environment modification.
I also added an Exception instead of going all the way to triggering a request that will invariably come back "unauthorized".
Note: I took the liberty to move the shared init logic to the base client, not sure if that goes in the direction that you guys have in mind.