[Feat] default to XDG_PICTURES_DIR for save path

[Uzaaft]

@mistricky I think this is a better, more saner default were we default to the xdg_pictures_dir or /Users/<Username>/Pictures on mac. Let me know what you think. I tried to update the docs where applicable, not sure if more is required.

[Uzaaft]

I'm not sure why, but I get this random as TOOD whenever I run it now:

[Uzaaft]

Fixed the issue above by just moving to pure lua space.

[mistricky]

@mistricky I think this is a better, more saner default were we default to the xdg_pictures_dir or /Users/<Username>/Pictures on mac. Let me know what you think. I tried to update the docs where applicable, not sure if more is required.

Hi @Uzaaft, I think set default value of save_path is great, but maybe there should have more logic for handle edge case, for instance, if the default path does not exist

[Uzaaft]

@mistricky I think this is a better, more saner default were we default to the xdg_pictures_dir or /Users/<Username>/Pictures on mac. Let me know what you think. I tried to update the docs where applicable, not sure if more is required.

Hi @Uzaaft, I think set default value of save_path is great, but maybe there should have more logic for handle edge case, for instance, if the default path does not exist

What do you mean with edge cases? Isn't the edge cases done here, i.e defaulting to xdg, enough?

[mistricky]

@mistricky I think this is a better, more saner default were we default to the xdg_pictures_dir or /Users/<Username>/Pictures on mac. Let me know what you think. I tried to update the docs where applicable, not sure if more is required.

Hi @Uzaaft, I think set default value of save_path is great, but maybe there should have more logic for handle edge case, for instance, if the default path does not exist

What do you mean with edge cases? Isn't the edge cases done here, i.e defaulting to xdg, enough?

I mean if somehow the value of XDG_PICTURES_DIR does not exists on disk, or if someone removed the ~/Pictures on his Mac, we should tell users what happened, and what they can do in this case.

Without default save_path, users should specify save_path explicitly, so the above case shouldn't happen, but if we set default value, we should check and throw more useful error message to users

[Uzaaft]

I believe the error that will appear if the folder doesn't exist will be as useful as the one you provide today. I.e:

Value of type () couldn't be pushed on the stack: Lua runtime error: No such file or directory (os error 2).

[mistricky]

LGTM