Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update dependencies #125

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

Uzaaft
Copy link
Contributor

@Uzaaft Uzaaft commented Jul 29, 2024

Compilation of the current release fails for me:
image

This PR fixes that by just bumping the deps. I took the liberty and updated most of the deps and fix breaking changes. The only outlier is the nvim-oxi crate.

One of the breaking changes requires a LineEnding character to be passed into one of the functions. I default this to \n and whatever the windows equivalent is.

@Uzaaft Uzaaft marked this pull request as ready for review July 29, 2024 09:53
@Uzaaft
Copy link
Contributor Author

Uzaaft commented Jul 29, 2024

Seems like the issue can be tracked to a new update of rust. Interesting...

Copy link
Owner

@mistricky mistricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thx for your job

@mistricky
Copy link
Owner

Hi @Uzaaft, Will there be future commits on this PR? If not I'll merge it into main branch

@mistricky mistricky merged commit 538b717 into mistricky:main Jul 30, 2024
@Uzaaft
Copy link
Contributor Author

Uzaaft commented Jul 30, 2024

@mistricky No. I won't be touching nvim-oxi. That shit is confusing me xD

@mistricky
Copy link
Owner

Yeah... FFI is really tricky thing to handle like what nvim-oxi did, if there a better solution to call Rust module in Lua, I would give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants