Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Blockly v10 support #12

Closed
ewpatton opened this issue Jul 27, 2023 · 3 comments · Fixed by #13
Closed

Update to Blockly v10 support #12

ewpatton opened this issue Jul 27, 2023 · 3 comments · Fixed by #13

Comments

@ewpatton
Copy link
Member

So there are at least two issues to worry about with the latest Blockly version

  1. The block dragger stuff is supposedly going away.
  2. Icons have been refactored, so right clicking on blocks is broken.

One of our new GSOC students also pointed out that there are phantom copies of blocks being created when they are dragged from the drawer when the multiselect plugin is enabled.

@HollowMan6
Copy link
Collaborator

HollowMan6 commented Jul 27, 2023

@ewpatton

I just tried Blockly v10 with the multi-select plugin. The multi-block dragging is still working, I haven't checked the details, but at least we can keep the dragging stuff untouched when upgrading to v10.

The right-click is broken. We do need to re-work on this, I will fix that.

@HollowMan6
Copy link
Collaborator

Just checked the v10 change log in detail. It's actually a piece of great news instead that drag surfaces are finally removed: google/blockly#7070 This plugin is built upon the fact that drag surfaces are disabled:

/**
* Disable the drag surface.
* @override
*/
Blockly.WorkspaceSvg.prototype.getBlockDragSurface = function() {
return null;
};

Now this patch is no longer needed!

@HollowMan6
Copy link
Collaborator

One of our new GSOC students also pointed out that there are phantom copies of blocks being created when they are dragged from the drawer when the multiselect plugin is enabled.

Fixed in: f148ffb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants