Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: re-remove block and workspace drag surfaces #7070

Merged
merged 8 commits into from
May 11, 2023

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented May 10, 2023

Reversion of reversion #6888

Reapplication of #6758

(Re) Fixes #6160

The details

Proposed changes

Removes the block drag surface and the workspace drag surface from Blockly.

Reason for changes

Both of these were implemented as a performance optimization, but have since become a performance sink. Removing these gives us a significant boost in FPS.

Breaking changes / updating / upgrading

Unless you were accessing the drag surface directly, this change should not affect you.

If you were accessing the drag surface directly, you should now access either the workspace svgGroup_ or the svgBlockCanvas_. Here is an example PR that updates the scroll-options plugin: https://github.com/google/blockly-samples/pull/1666/files

Note that we are planning to create more formal get methods to replace these properties in the future (see #7157). If you have opinions about this please feel welcome to leave comments there!

@BeksOmega BeksOmega requested a review from a team as a code owner May 10, 2023 22:01
@BeksOmega BeksOmega requested a review from cpcallen May 10, 2023 22:01
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 10, 2023
@BeksOmega BeksOmega changed the title fix: re-remove block and workspace drag surfaces fix!: re-remove block and workspace drag surfaces May 11, 2023
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 11, 2023
@BeksOmega BeksOmega merged commit 455c195 into google:develop May 11, 2023
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Jun 22, 2023
@rockyxia
Copy link

rockyxia commented Aug 3, 2023

Dragging a blocklyDraggable element onto a blocklyToolboxDiv element will be obstructed by blocklyToolboxDiv, making it impossible to elevate the blocklyDraggable element level. Originally, raising the blocklyBlockDragSurface element level was sufficient. How can we solve this problem?

blocklyDraggable元素拖拽到blocklyToolboxDiv元素会被blocklyToolboxDiv遮挡,无法提升blocklyDraggable元素层级,原来通过提升blocklyBlockDragSurface元素层级即可,如何解决这个问题?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove workspace drag surface and block drag surface
5 participants