Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After copying once, moving a block copies it again #20

Closed
laurensvalk opened this issue Aug 12, 2023 · 6 comments · Fixed by #21
Closed

After copying once, moving a block copies it again #20

laurensvalk opened this issue Aug 12, 2023 · 6 comments · Fixed by #21

Comments

@laurensvalk
Copy link
Contributor

In the first few seconds, everything works fine. After copying something though, it escalates quickly.

This appears to be introduced in 0.1.7.

update-2023-08-12_10.25.16.mp4
@HollowMan6
Copy link
Collaborator

I’ve already noticed that yesterday, and that looks like to be introduced as of the blockly version bump. I haven’t looked through what they have changed. A version downgrade should be a temporary workaround. https://github.com/mit-cml/workspace-multiselect/pull/19/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R47

@HollowMan6
Copy link
Collaborator

Looks like it should be their use of the new render management system in v10.1.x that caused this. https://github.com/google/blockly/pull/7307/files

Haven't figured out how to fix this still...

@HollowMan6 HollowMan6 mentioned this issue Aug 12, 2023
Closed
1 task
@HollowMan6
Copy link
Collaborator

It turned out to be an upstream issue: google/blockly#7383

My suggestion is that, don't use Blockly version 10.1.x until that issue is fixed. It should be fine to keep the Blockly version as 10.1.1 here https://github.com/mit-cml/workspace-multiselect/blob/main/package.json#L47 We don't need to release again for downgrading as it's just a devDependency, the peerDependency is still Blockly v10.0.0, so users will face no issue when they integrate this plugin into their own project. If you want to develop this plugin, just downgrade the Blockly version in devDependencies to v10.0.2 manually.

We can close this issue for now and I will follow up on the upstream issue.

@HollowMan6
Copy link
Collaborator

I have submitted a PR to fix this in the upstream: google/blockly#7384

HollowMan6 added a commit to HollowMan6/workspace-multiselect that referenced this issue Aug 13, 2023
@HollowMan6
Fix to unselect blocks in all workspaces when click on the workspace …
70ebd50 
…background

Also downgrade to blockly v10.0.2 to resolve mit-cml#20

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6 HollowMan6 mentioned this issue Aug 13, 2023
Merged
HollowMan6 added a commit to HollowMan6/workspace-multiselect that referenced this issue Aug 13, 2023
@HollowMan6
Fix to unselect blocks in all workspaces when click on the workspace …
b0ff8df 
…background

Also downgrade to blockly v10.0.2 to resolve mit-cml#20

Signed-off-by: Hollow Man <hollowman@opensuse.org>
HollowMan6 added a commit to HollowMan6/workspace-multiselect that referenced this issue Aug 14, 2023
@HollowMan6
Fix to unselect blocks in all workspaces when click on the workspace …
9893cc4 
…background

Also upgrade to blockly v10.1.2 to resolve mit-cml#20

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6
Copy link
Collaborator

A new release has been made: https://github.com/google/blockly/releases/tag/blockly-v10.1.2

@laurensvalk
Copy link
Contributor Author

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.1.8: Bugs fix HollowMan6/workspace-multiselect
2 participants
@laurensvalk @HollowMan6