multiselect_controls: Fix crash on selecting a second time #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the case where `element` does not exist.
laurensvalk
changed the title
|
This looks perfectly fine to me. (I didn't test with Zelos renderer when I was developing this plugin, not sure if there may exist other issues in addition to this) cc: @ewpatton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where
elementdoes not exist. This fixes the crash, but I'm not familiar enough with the code base to know if this might have any side effects.To reproduce:
Zelosrenderer. It does not appear to happen with other renderers.shiftkey held down.shift, then press again to repeat selection.update-2023-08-11_11.06.21.mp4