Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Important] Fix ../lib/ds.min.js not Found #2

Merged
merged 1 commit into from
Aug 3, 2022
Merged

[Important] Fix ../lib/ds.min.js not Found #2

merged 1 commit into from
Aug 3, 2022

Conversation

HollowMan6
Copy link
Collaborator

Sorry I ignored that only the code under src folder will be uploaded to the NPM, so there's an error ../lib/ds.min.js not found that blocks the plugin from integrating from NPM. A new release must be drafted to fix this.

Also I made a small change to the code, so that right now, the block can get selected when it is movable or deletable, without the need to satisfy the both at the same time.

I have also tested the integration with Sandspiel Studio since previously they showed some interest in this feature: google/blockly-samples#267 (comment) , and it works OK:

GIF 29-07-2022 13-13-53

Signed-off-by: Hollow Man hollowman@opensuse.org

@HollowMan6
Copy link
Collaborator Author

Once this PR: ThibaultJanBeyer/DragSelect#128 (comment) gets merged and a new release of DragSelect gets drafted (soon), we can remove the ds.min.js. But right now, we still need it

@ewpatton
Copy link
Member

Hmm. The lint step when building throws a lot of errors because of the fact that the ds file is minified. There must be another way we can address this issue.

@mark-friedman
Copy link
Contributor

FYI, there appears to be a non-minified version at https://dragselect.com/v2/DragSelect.js

@HollowMan6
Copy link
Collaborator Author

Hmm. The lint step when building throws a lot of errors because of the fact that the ds file is minified. There must be another way we can address this issue.

@ewpatton Okay, sorry I didn't notice that. Have exclude that from eslint check.

FYI, there appears to be a non-minified version at https://dragselect.com/v2/DragSelect.js

@mark-friedman Thanks for your suggestion, actually that won't work still, even for the non-minified version, since they have a completely different coding style with Google's.

src/lib/ds.min.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Signed-off-by: Hollow Man <hollowman@opensuse.org>
@ewpatton ewpatton merged commit f191546 into mit-cml:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants