Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.10: Support for Blockly v10.2.0+; Fix icon related issues #26

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

HollowMan6
Copy link
Collaborator

@HollowMan6 HollowMan6 commented Nov 14, 2023

Resolve #25
Resolve #11
Resolve #27

@HollowMan6
Copy link
Collaborator Author

Upgrade the Blockly paste API starting from 10.2.0

cc @ewpatton for reviewing

@laurensvalk
Copy link
Contributor

laurensvalk commented Nov 14, 2023

This fixes copy/paste with CTRL+C/CTRL+V (thanks!), but there is a duplicate portion of code for the right-click context paste which has not been updated here, which still crashes in the same way as #25.

This could probably use the same update (or share the code).

@HollowMan6
Copy link
Collaborator Author

Now fixed the context menu as well (forgot we also have a paste in the workspace menu). Thanks!

@laurensvalk
Copy link
Contributor

I confirm. Thanks!

Resolve mit-cml#25
Resolve mit-cml#11

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6
Copy link
Collaborator Author

  • Added back those checks as they are still necessary.
  • Now we stringify the blocks data when we store them.

@laurensvalk
Copy link
Contributor

This also works 👍

Resolve mit-cml#27

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6 HollowMan6 changed the title v0.1.10: Support for Blockly v10.2.0+ v0.1.10: Support for Blockly v10.2.0+; Fix icon related issues Nov 14, 2023
@laurensvalk
Copy link
Contributor

Can also confirm that the last commit with the fix for #27 is working. Thanks!

package.json Show resolved Hide resolved
Copy link
Member

@ewpatton ewpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in the future please try to keep unrelated changes to separate PRs so that they can be reviewed independently.

@ewpatton ewpatton merged commit 6e8da79 into mit-cml:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants