Persistent log #10
Merged
Persistent log #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for three durability levels:
- None: nothing is written to the log
- Buffered: writes are buffered in the application and possibly in the
file system (no crash safety, but higher throughput)
- SyncImmediately: writes are synchronously written to disk
immediately (currently one by one, but we'll want to use batches).
"Buffered" is the default durability level; `Base::new()` now accepts a
second argument that allows specifying it explicitly.
…ss for base nodes
…t getting dropped.
This adds support for three durability levels:
- None: nothing is written to the log
- Buffered: writes are buffered in the application and possibly in the
file system (no crash safety, but higher throughput)
- SyncImmediately: writes are synchronously written to disk
immediately (currently one by one, but we'll want to use batches).
"Buffered" is the default durability level; `Base::new()` now accepts a
second argument that allows specifying it explicitly.
…ss for base nodes
…t getting dropped.
This explains the behaviour observed by @jmftrindade, but unfortunately also means that our plan of using a test-specific `Drop` impl to clear up durable logs from tests is not going to work.
…ead of Some(empty vec) from Base::on_input.
|
One question: if we always end up treating |
|
Also, don't worry too much about the conflicts with |
|
Oh, nice, that significantly reduced the number of conflicts too! :D |
|
@jmftrindade I'll take a stab at merging |
|
Travis failures are due to rust-lang/rustup#1062 |
…et the max throughput.
|
Great job 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.