Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

prevent panic in TextUnmarshallerHookFunc #328

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

prochac
Copy link
Contributor

@prochac prochac commented Apr 18, 2023

if reflect.Kind is reflect.String, it doesn't necessary means it's string type. It can be string-based type

if reflect.Kind is reflect.String, it doesn't necessary means it's
`string` type. It can be string-based type
@prochac
Copy link
Contributor Author

prochac commented Apr 18, 2023

Fixes #327

@prochac
Copy link
Contributor Author

prochac commented Apr 18, 2023

It's very questionable if json.Number should be treated as string, and not as a number.
But it's very handy for the given use-case from test, where json.Number can be parsed as big.Int

@prochac
Copy link
Contributor Author

prochac commented Jul 28, 2023

@mitchellh with all respect, does anyone helping you with PRs? There are many open with bug fixes that should be merged into upstream.

@prochac
Copy link
Contributor Author

prochac commented Sep 8, 2023

@mitchellh ping

@chrisgacsal
Copy link

@mitchellh Could you please take a look on this fix? Many thanks!

@jkroepke
Copy link

Thanks, it works for me.

@mitchellh I would appreciate this, if you could merge this.

@prochac
Copy link
Contributor Author

prochac commented Dec 16, 2023

@mitchellh Will this affect the future of this project?

https://www.theregister.com/2023/12/15/hashimoto_departs_hashicorp/

@mitchellh mitchellh merged commit 8508981 into mitchellh:main Dec 16, 2023
@mitchellh
Copy link
Owner

@mitchellh Will this affect the future of this project?

https://www.theregister.com/2023/12/15/hashimoto_departs_hashicorp/

Not specifically that.

As many here have probably noticed, I’ve barely been maintaining this project for years. That’s a mixture of a few things. One is that this project has worked well for my needs for a long time so there was no need to improve it for myself personally. Another is that I’ve been using Go less and less personally so I just haven’t been focused here. Etc. I plan on archiving this project sometime soon, and welcome any forks at this point…

@sagikazarmark
Copy link

@mitchellh We use mapstructure in Viper extensively. I'd be happy to maintain a fork. Even under a common place like https://github.com/go-viper if other people are interested in maintenance.

@prochac
Copy link
Contributor Author

prochac commented Dec 17, 2023

@sagikazarmark Terraform should show some personal interest in maintenance as well 😁
https://github.com/hashicorp/terraform/blob/654fd0041cac8f609e46af27be498aadf92aefe7/go.mod#L65-L73
Like OpenTofu 🙃
https://github.com/opentofu/opentofu/blob/5880b4964575b28d7272fa4a5c04afeef1bf0f3d/go.mod#L60-L68

With MIT license, anybody can create a fork. No need to transfer the project.
FYI, here is a list of importers. Viper looks like a good umbrella.
https://pkg.go.dev/github.com/mitchellh/mapstructure?tab=importedby

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants