Skip to content

Commit

Permalink
chore: fix template linting complaints
Browse files Browse the repository at this point in the history
  • Loading branch information
alexlafroscia committed Jun 24, 2020
1 parent 7602d25 commit 4fd4666
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion .template-lintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
"use strict";

module.exports = {
extends: "octane",
extends: "recommended",
rules: {
"no-triple-curlies": false,
},
};
2 changes: 1 addition & 1 deletion tests/dummy/app/templates/components/dummy-application.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
{{ember-islands}}
{{/if}}

<button {{action 'toggleIslandComponents'}}>Toggle Island Components</button>
<button type="button" {{action 'toggleIslandComponents'}}>Toggle Island Components</button>
2 changes: 1 addition & 1 deletion tests/dummy/app/templates/components/nested-component.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<p data-test-nested-component-message>A nested component</p>

<button id='nested-component-toggle-expanded' {{action 'nestedAction'}}>Nested component action</button>
<button type="button" id='nested-component-toggle-expanded' {{action 'nestedAction'}}>Nested component action</button>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<p data-test-top-level-component-message>top level component</p>

<button id="toggle-expanded" {{action 'toggleIsExpanded'}}>Expand something</button>
<button type="button" id="toggle-expanded" {{action 'toggleIsExpanded'}}>Expand something</button>

{{#if isExpanded}}
<p id="expanded-content">Expanded!</p>
Expand Down

0 comments on commit 4fd4666

Please sign in to comment.