didReceiveAttrs not called anymore

[patric-eberle]

Ember 3.13.1
ember-islands 1.5.1

It seems like the initial handling of didReceiveAttrs when initializing a component with factoryFor has changed (see emberjs/ember.js#17534 ). We run into this problem because a part of our components was relying on this.

To me it looks, like this hook should be called manually now, to preserve the normal component lifecycle. Maybe extend add the trigger('didReceiveAttrs') to the following code in get-render-component.js?

// ...
let componentInstance = component.create(attrs);

componentInstance.trigger('didReceiveAttrs');
componentInstance.appendTo(element);

return componentInstance;
// ...

[mitchlloyd]

Thanks for reporting, Patric. If this behavior changed I wonder if there is some way to apply a fix that wouldn’t potentially break past versions of ember by invoking didReceiveAttrs twice.

…

On Tue, Jan 21, 2020 at 2:19 AM Patric Eberle ***@***.***> wrote: Ember 3.13.1 ember-islands 1.5.1 It seems like the initial handling of didReceiveAttrs when initializing a component with factoryFor has changed (see emberjs/ember.js#17534 <emberjs/ember.js#17534> ). We run into this problem because a part of our components was relying on this. To me it looks, like this hook should be called manually now, to preserve the normal component lifecycle. Maybe extend add the trigger('didReceiveAttrs') to the following code in get-render-component.js? // ...let componentInstance = component.create(attrs); componentInstance.trigger('didReceiveAttrs');componentInstance.appendTo(element); return componentInstance;// ... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#58?email_source=notifications&email_token=AAADWQI42GTU325FBAZFY3LQ63D3BA5CNFSM4KJQ4QTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IHSYBGQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADWQO62R2A26LCYHQISFLQ63D3BANCNFSM4KJQ4QTA> .

[patric-eberle]

@mitchlloyd true. I'm not that familiar with Ember anymore unfortunately... The only thing that came to my mind is checking the current Ember version? Not very nice, but it would work I guess.

[mitchlloyd]

Maybe @rwjblue could advise a bit? I looks like we could inspect the Ember version to fix this bug (>= 3.2.0) and then trigger the didReceiveAttrs hook, but I'm curious if there is a more official way. Perhaps I could use the component manager directly?

[rwjblue]

Yeah, I think detecting Ember version is the best bet. I don't think we expose the managers themselves (though that is a good idea and would help libs like this to avoid having to care about these specific nuances).

[xtagon]

Is there a solution or workaround for this? Does ember-islands support Ember 3.x?

Thanks in advance 👍