Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: adding more edgecases #43

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Bugfix: adding more edgecases #43

merged 1 commit into from
Oct 10, 2021

Conversation

jacobgarder
Copy link
Contributor

Adding some more edge-cases where the API is not using strict camelCase:

"surrogate_ip" should translate to "surrogateIP"
"surrogate_ip_enforced_for_known_browsers" should translate to "surrogateIPEnforcedForKnownBrowsers"

Also replaceing the if-statements with a dictionary for translating edgecases.

@mitchos mitchos self-assigned this Oct 10, 2021
@mitchos mitchos changed the base branch from main to develop October 10, 2021 23:04
Copy link
Owner

@mitchos mitchos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.

If we keep finding more edge cases relating to the word 'IP' then we should write something that will handle it for all cases.

Happy to add this for now as it's not exactly onerous to add a few more if we find them.

@mitchos mitchos merged commit ae80aa8 into mitchos:develop Oct 10, 2021
@mitchos mitchos added the bug Something isn't working label Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants