fix: prevent Iterator to loop forever #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the Zscaler-API is behaving a bit odd for sublocations. It does not care about the page query-param.
A call to :
/locations/30920164/sublocations?page=10
will still produce the same set of sublocations as/locations/30920164/sublocations?page=1
This causes the Iterator to go into an infinite loop when trying to list all sub locations of a parent location as it does not stop until it gets an empty list as response.
Either we do not use the Iterator for sublocations or, as I suggest we simply add
max_pages=1
to the call as it will only be one page anyway.