Incorporates changes to make MITxOnline work with Tutor #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkachel
force-pushed
the
jkachel/tutor-openedx-changes
branch
from
74db9c8 to
9a965e8
Compare
Codecov Report
@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
+ Coverage 82.44% 82.92% +0.48%
==========================================
Files 315 313 -2
Lines 13525 13443 -82
Branches 952 954 +2
==========================================
- Hits 11151 11148 -3
+ Misses 2104 2027 -77
+ Partials 270 268 -2 |
|
@jkachel Once this PR is approved and merged, can we still use the Devstack-based edX installation with MIT xOnline? |
Yes; the actual changes to the app are additive. |
jkachel
force-pushed
the
jkachel/tutor-openedx-changes
branch
from
6186764 to
9ffca12
Compare
…nstance. * Adds a host alias for local.overhang.io (remember to set OPENEDX_IP) * Updates configure_instance to take a --tutor option, which will switch URLs to the local.overhang.io hostname.
…han doing it manually
…y easier to cut and paste
…nstance for Tutor deployments now
…nightly flag; updating docs for same; updating overall Tutor docs with a few more things after testing with nightly/dev
jkachel
force-pushed
the
jkachel/tutor-openedx-changes
branch
from
e31bcfb to
d48a24f
Compare
rachellougee
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
n/a
What's this PR do?
Documentation updates and some minor code changes to facilitate using MITx Online with Tutor.
This also nerfs the old Refine Admin docs; they were out of date (we don't have a specific OIDC setup for that anymore).
How should this be manually tested?
Documentation/Tutor Deployment:
Note that Open edX's Tutor distribution replaces devstack - you can run them at the same time (they expose different ports) but I at least found that to be a bit confusing, not to mention resource intensive. If you're running this on an arm64/Apple Silicon machine, there are specific docs for that (you'll have to rebuild the
openedximage anyway but there are other things that need to be done).Build the documentation and then read it:
This will build the documentation, then run a nginx container on port 7888 pointed at the built docs (or just open it from
dist/sphinx, that works too).Follow the documentation at
docs/source/configuration/tutor.rst(or http://localhost:7888/configuration/tutor.html if you did the Docker thing above). It should work.Support:
configure_instancecommand now accepts a--tutorflag - if you specify this, it will use "local.overhang.io" instead of "edx.odl.local:18000" for URLs in the appropriate spots. (This will get tested as part of the Tutor deployment docs but if you want to test it manually, you can - just check for different URLs in the OAuth2 application records.)local.overhang.io, and it should resolve to what you've setOPENEDX_IPto rather than what's in DNS.Any background context you want to provide?
HQ thread
devstack deprecation