Added conversion to array when string is detected on cci in csv2inspec #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am having issues signing at the moment, will have it signed and ready to go by tomorrow |
If you continue to have problems with the DCO don't worry about it because I can bypass it on my end. |
Bialogs
suggested changes
Aug 5, 2021
Changed to detect if it is an array, rather than checking if it is a string.
Bialogs
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the examples to test the csv2inspec, and noticed that all of the ccis existed as a string.
Fix:
Added a case for if the cci was a string, in which it would convert it into an array.