Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message style improvements #26

Merged
merged 6 commits into from
Jul 15, 2020
Merged

Message style improvements #26

merged 6 commits into from
Jul 15, 2020

Conversation

alilleybrinker
Copy link

No description provided.

@alilleybrinker alilleybrinker added the C-enhancement Category: Enhancement New feature or request label Jul 14, 2020
@alilleybrinker alilleybrinker added this to the Pact Matching FFI v1 milestone Jul 14, 2020
cstepanian
cstepanian previously approved these changes Jul 14, 2020
View reviewed changes
@alilleybrinker
Copy link
Author

alilleybrinker commented Jul 15, 2020 •
edited
Loading

Looks like the failing check is due to a failed property-based test in pact_verifier_cli, which we're not touching, so I'm inclined to override it, although it looks like there are also changes missing from the pact_matching_ffi branch that would block merging, so I'll need to fix that first.

@alilleybrinker
Copy link
Author

Rebased on the latest from the pact_matching_ffi branch, and pushed again. It'll rerun the checks, and the property-based test (which is probabilistic) might fail again, and is irrelevant. I'll let it finish just to make sure the rebase didn't break anything, but if it blocks on the same issue I'll override it.

@alilleybrinker
Copy link
Author

Ah, looks like the rebase also means it needs a new approval from @cstepanian.

@alilleybrinker
Copy link
Author

sigh, yeah, that test failed again. It's frustrating that upstream doesn't rigorously require their own commits to pass CI (it seems) because 1) it breaks our builds, and 2) it seems to periodically add a number of warnings, as we discussed yesterday. At any rate, I'm going to temporarily turn off the requirement that checks pass, merge this, and then turn the requirement back on.

@alilleybrinker alilleybrinker merged commit 7a68902 into pact_matching_ffi Jul 15, 2020
@alilleybrinker alilleybrinker deleted the message_style_improvements branch July 15, 2020 20:14
alilleybrinker added a commit that referenced this pull request Jul 30, 2020
@alilleybrinker
Message style improvements (#26)
d729281 
Improvements to existing message implementation to better fit agreed-on
patterns and consistently follow design requirements. Not yet fully
finished, but good enough to merge.
alilleybrinker added a commit that referenced this pull request Jul 30, 2020
@alilleybrinker
Message style improvements (#26) (#27)
a42e1db 
Improvements to existing message implementation to better fit agreed-on
patterns and consistently follow design requirements. Not yet fully
finished, but good enough to merge.
alilleybrinker added a commit that referenced this pull request Sep 23, 2020
@alilleybrinker
Message style improvements (#26) (#27)
0af4921 
Improvements to existing message implementation to better fit agreed-on
patterns and consistently follow design requirements. Not yet fully
finished, but good enough to merge.
alilleybrinker added a commit that referenced this pull request Nov 4, 2020
@alilleybrinker
Message style improvements (#26) (#27)
c7cb459 
Improvements to existing message implementation to better fit agreed-on
patterns and consistently follow design requirements. Not yet fully
finished, but good enough to merge.
alilleybrinker added a commit that referenced this pull request Dec 4, 2020
@alilleybrinker
Message style improvements (#26) (#27)
940e29b 
Improvements to existing message implementation to better fit agreed-on
patterns and consistently follow design requirements. Not yet fully
finished, but good enough to merge.
alilleybrinker added a commit that referenced this pull request Feb 2, 2021
@alilleybrinker
Message style improvements (#26) (#27)
4359992 
Improvements to existing message implementation to better fit agreed-on
patterns and consistently follow design requirements. Not yet fully
finished, but good enough to merge.
alilleybrinker added a commit that referenced this pull request Apr 22, 2021
@alilleybrinker
Message style improvements (#26) (#27)
44700c8 
Improvements to existing message implementation to better fit agreed-on
patterns and consistently follow design requirements. Not yet fully
finished, but good enough to merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstepanian cstepanian cstepanian approved these changes

Assignees
No one assigned
Labels
C-enhancement Category: Enhancement New feature or request
Projects
None yet
Milestone
Pact Matching FFI v1
Development

Successfully merging this pull request may close these issues.
2 participants
@alilleybrinker @cstepanian