forked from pact-foundation/pact-reference
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metadata key/value iteration #28
Merged
alilleybrinker
merged 4 commits into
pact_matching_ffi
from
additional_message_improvements
Aug 6, 2020
Merged
Added metadata key/value iteration #28
alilleybrinker
merged 4 commits into
pact_matching_ffi
from
additional_message_improvements
Aug 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
added
C-enhancement
Category: Enhancement New feature or request
A-ffi
Area: Foreign Function Interface
labels
Jul 30, 2020
This commit corrects the leaking of strings to C, to use into_raw() to make sure ownership is transferred. It also adds a `Drop` implementation for the `MetadataPair` type to ensure the inner strings are freed.
This converts some `*mut c_char` into `*const c_char`, modifying `MetadataPair::drop` to cast back to `*mut c_char` at deletion, with a comment explaining why this cast is safe.
After discussion between @cstepanian and I, we found that the |
cstepanian
approved these changes
Aug 5, 2020
alilleybrinker
added a commit
that referenced
this pull request
Sep 23, 2020
This commit adds the ability to get and iterate over metadata for Pact messages.
alilleybrinker
added a commit
that referenced
this pull request
Nov 4, 2020
This commit adds the ability to get and iterate over metadata for Pact messages.
alilleybrinker
added a commit
that referenced
this pull request
Dec 4, 2020
This commit adds the ability to get and iterate over metadata for Pact messages.
alilleybrinker
added a commit
that referenced
this pull request
Feb 2, 2021
This commit adds the ability to get and iterate over metadata for Pact messages.
alilleybrinker
added a commit
that referenced
this pull request
Apr 22, 2021
This commit adds the ability to get and iterate over metadata for Pact messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple notes:
#[repr(C)]
type calledMetadataPair
that contains the key and value strings, and has an associatedmetadata_pair_delete
function.Message
. If theMessage
you're iterating over is deallocated, that pointer will be invalid.