Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-insta: exclude flag doesn't take multiple arguments #519

Closed
ajwerner opened this issue Jul 1, 2024 · 1 comment · Fixed by #520
Closed

cargo-insta: exclude flag doesn't take multiple arguments #519

ajwerner opened this issue Jul 1, 2024 · 1 comment · Fixed by #520
Labels
bug Something isn't working

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Jul 1, 2024

What happened?

I ran my test with multiple exclude flags.

Reproduction steps

cargo insta test --workspace --all-targets --exclude a --exclude b

error: The argument '--exclude <SPEC>' was provided more than once, but cannot be used multiple times

USAGE:
    cargo insta test --all-targets --exclude <SPEC> --test-runner <test-runner> --unreferenced <unreferenced> --workspace

For more information try --help

Insta Version

cargo-insta 1.39.0

rustc Version

No response

What did you expect?

I expected it to behave like cargo test:

--exclude SPEC…
Exclude the specified packages. Must be used in conjunction with the --workspace flag. This flag may be specified multiple times and supports common Unix glob patterns like *, ? and []. However, to avoid your shell accidentally expanding glob >patterns before Cargo handles them, you must use single quotes or double quotes around each pattern.

@ajwerner ajwerner added the bug Something isn't working label Jul 1, 2024
@ajwerner
Copy link
Contributor Author

ajwerner commented Jul 1, 2024

I'll put up a PR for this, just wanted to file it first.

ajwerner added a commit to ajwerner/insta that referenced this issue Jul 1, 2024
ajwerner added a commit to ajwerner/insta that referenced this issue Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant