Improve cargo insta help output
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo insta help test` previously only reported:
--unreferenced <unreferenced> Controls what happens with unreferenced snapshots
This commit changes it to:
--unreferenced <unreferenced> Controls what happens with unreferenced snapshots [default: ignore] [possible
values: ignore, warn, reject, delete, auto]
`cargo insta help test` previously only reported:
--test-runner <test-runner> Picks the test runner
This commit changes it to:
--test-runner <test-runner> Picks the test runner [default: auto] [possible values: auto, cargo-test,
nextest]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we would bump the MSRV to 1.64.0 we could switch from structopt to clap, which would let us further improve the
cargo insta help testoutput by grouping options with thehelp_headingoption (see astral-sh/ruff#2155 for an example) ... and then we could also have theTestRunnerandUnreferencedSnapshotsenums derive ValueEnum, which would mean we would no longer have to duplicate thepossible_valuesincargo-insta.But seeing that you haven't yet decided on the MSRV issue #289, I just made the improvements that structopt supports :)