Allow trailing commas in inline snapshots #472
Conversation
There was a problem hiding this comment.
Awesome @narpfel
Is the comma be removed when a snapshot is written? If so, do we want that or do we prefer to retain it?
We don't have great tests for this sort of thing IIRC, so it's worthwhile checking by hand that the replacement behavior is what's expected (or ofc +1 to adding a test...)
(@mitsuhiko is the maintainer so this is just a comment from another contributor)
insta/src/macros.rs
Outdated
| @@ -321,7 +319,7 @@ macro_rules! assert_debug_snapshot { | |||
| // the value. This allows us to implement other macros with a small wrapper. All | |||
| // snapshot macros eventually call this macro. | |||
| // | |||
| // The macro handles optional trailing commas in file snapshots. | |||
| // This macro is expected to handle trailing commas. | |||
There was a problem hiding this comment.
| // This macro is expected to handle trailing commas. | |
| // This macro handles trailing commas. |
There was a problem hiding this comment.
Yes cool! (FYI GH also allows "Accept suggestion")
The comma is kept, for example in this test: 6b28cb3#diff-42101e5a83cd4bee69fc68a5258dfbeafa0c657945e327f0aee0fd05ab309d58R35-R38 |
Perfect! |
After using mitsuhiko/insta-cmd#12 for a bit, I noticed that
cargo insta testwould not pick up on mismatches in inline snapshots with trailing commas.This PR fixes that and also allows trailing commas for inline snapshots in other macros.
This PR uses code from #454 by @max-sixty.