Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add assert_compact_debug_snapshot #514

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: add assert_compact_debug_snapshot #514

merged 2 commits into from
Jul 29, 2024

Conversation

jrandolf
Copy link
Contributor

The pretty-print format of debug is generally extremely verbose. It's great for complex objects, but for simple ones, the compact form of debug is far more suitable. This PR adds a assert_compact_debug_snapshot similar to assert_compact_json_snapshot.

@max-sixty max-sixty requested a review from mitsuhiko July 7, 2024 19:19
@max-sixty
Copy link
Collaborator

@jun-sheaf while we wait for a review — could we merge master and ensure the tests pass?

@jrandolf
Copy link
Contributor Author

@max-sixty That error is not related to this PR. Nevertheless, I've added the fix.

@max-sixty
Copy link
Collaborator

max-sixty commented Jul 10, 2024

@max-sixty That error is not related to this PR.

The fix is on master so if you merge master it'll resolve...

And the docs break does seem to be from this PR...

@max-sixty max-sixty merged commit 84e2045 into mitsuhiko:master Jul 29, 2024
14 checks passed
@max-sixty
Copy link
Collaborator

Merged — thanks @jun-sheaf . If you want to also add an entry to the Changelog in a PR then great. Otherwise someone can do it when releasing.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2024

Merged — thanks @jun-sheaf . If you want to also add an entry to the Changelog in a PR then great. Otherwise someone can do it when releasing.

See #552

I'd like to try to this new feature when a new version (1.40.0) out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants