Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cargo metadata collection #536

Closed
wants to merge 18 commits into from

Conversation

max-sixty
Copy link
Collaborator

It was previously a bit disparate and difficult to verify. This simplifies & unifies the code.

It builds on #532, so that should merge first.

I'm still not 100% confident — ideally we'd have some integration tests with various workspace configurations...

@max-sixty
Copy link
Collaborator Author

I realize I forgot about this and re-implemented half of it in #532, apologies. Given it makes the code simpler and easier to review, I'll copy the improvements over to there and close this.

@max-sixty max-sixty closed this Aug 2, 2024
@max-sixty max-sixty deleted the simplify-cargo-metadata branch August 2, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant