Generalise filters to support IntoIterator types, not just Vecs
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @eopb ! Would you be able to add an entry to the changelog? |
Currently filters must be `Vec`s:
```rust
insta::with_settings!({filters => vec![
(r"tmp\/\.tmp.*\/", "[TEMPDIR]"),
(r"var\/.*\/\.tmp.*\/", "[TEMPDIR]"),
]}, { }
```
However, using an array could be cleaner:
```rust
insta::with_settings!({filters => [
(r"tmp\/\.tmp.*\/", "[TEMPDIR]"),
(r"var\/.*\/\.tmp.*\/", "[TEMPDIR]"),
]}, { }
```
And finally, it enables the filters to be extracted into a `const`:
```rust
const FILTERS: [(&'static str, &'static str); 2] = [
(r"tmp\/\.tmp.*\/", "[TEMPDIR]"),
(r"var\/.*\/\.tmp.*\/", "[TEMPDIR]"),
];
insta::with_settings!({filters => FILTERS}, { }
```
eopb
force-pushed
the
push-sutvxzqnpmop
branch
from
033931c to
b786d7c
Compare
|
@max-sixty added a changelog entry with a force push 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently filters must be
Vecs:However, using an array could be cleaner:
And finally, it enables the filters to be extracted into a
const: