Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and change the version in ytmp3 module dynamically #27

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mitsuki31
Copy link
Owner

@mitsuki31 mitsuki31 commented Aug 16, 2024

Overview

Instead using a constant value that needs to be changed when release, we change it to use dynamic method which retrieve the version information from package.json file.

This also addressed the issue with versions 1.0.1 and 1.0.2, where the version in ytmp3 module was not altered and remained at 1.0.0.

Testing

You can compare both value of version from the ytmp3 module and package.json file.

node -p "require('ytmp3-js').version" && node -p "require('ytmp3-js/package.json').version"

@mitsuki31 mitsuki31 added refactor Refactor and enhancement changes bugfix Fixes any issue and bug labels Aug 16, 2024
@mitsuki31 mitsuki31 self-assigned this Aug 16, 2024
@mitsuki31 mitsuki31 merged commit 1a5cd75 into master Aug 16, 2024
9 checks passed
@mitsuki31 mitsuki31 deleted the refactor/dynamic-versioning-in-ytmp3-module branch August 16, 2024 01:07
@mitsuki31 mitsuki31 added the patch Patch changes label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes any issue and bug patch Patch changes refactor Refactor and enhancement changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant