Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivityImageUtils.getScaledScreenshot crash #728

Closed
matteinn opened this issue Mar 23, 2021 · 1 comment · Fixed by #729
Closed

ActivityImageUtils.getScaledScreenshot crash #728

matteinn opened this issue Mar 23, 2021 · 1 comment · Fixed by #729

Comments

@matteinn
Copy link
Contributor

matteinn commented Mar 23, 2021 •
edited
Loading

Hi!
I'm noticing some crashes on the 5.8.7 android sdk, mainly on Android 8 devices.

`Fatal Exception: java.lang.IllegalArgumentException
width and height must be > 0

com.mixpanel.android.util.ActivityImageUtils.getScaledScreenshot (ActivityImageUtils.java:16)`

Possibly related to #711
@matteinn matteinn mentioned this issue Mar 24, 2021
Merged
@zihejia
Copy link
Contributor

zihejia commented Mar 24, 2021

hi @matteinn , sorry for the inconvenience and thanks for providing the PR. I will do a patch release for this.

zihejia added a commit that referenced this issue Mar 25, 2021
@zihejia
Merge pull request #729 from matteinn/feature/#728-prevent-crash-on-g…
8639aa2 
…etscaledscreenshot

Crash prevention on getScaledScreenshot when rootView is not measured yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Crash prevention on getScaledScreenshot when rootView is not measured yet matteinn/mixpanel-android
2 participants
@matteinn @zihejia