Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing config.secret to types #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add missing config.secret to types #225

wants to merge 1 commit into from

Conversation

gierschv
Copy link

@gierschv gierschv commented Oct 2, 2023

The release 0.18.0 broke the usage of this library using TypeScript and secret in the config:

error TS2345: Argument of type '{ host: string; secret: string; debug: boolean; }' is not assignable to parameter of type 'Partial<InitConfig>'.
Object literal may only specify known properties, and 'secret' does not exist in type 'Partial<InitConfig>'.

@lsthornt
Copy link

lsthornt commented Nov 6, 2023

Just here to add a +1 confirming that this change works in our codebase, and fixes the type issue noted in the description.

@willemclarke willemclarke mentioned this pull request Dec 14, 2023
Open
@boredland boredland mentioned this pull request Apr 11, 2024
Closed
@mdwallis
Copy link

Following up on this thread to see if and when the PR will be merged. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triqi triqi triqi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gierschv @lsthornt @mdwallis @triqi